[webkit-reviews] review requested: [Bug 29031] [v8] speed up access to windows impl from various methods : [Attachment 39853] Second iteration

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 21 08:53:57 PDT 2009


anton muhin <antonm at chromium.org> has asked  for review:
Bug 29031: [v8] speed up access to windows impl from various methods
https://bugs.webkit.org/show_bug.cgi?id=29031

Attachment 39853: Second iteration
https://bugs.webkit.org/attachment.cgi?id=39853&action=review

------- Additional Comments from anton muhin <antonm at chromium.org>
Another pass.  It passes newly added layout tests.

The major difference is lookupDOMWrapper is restored in accessors checks.  I
believe the reason is not security, but some technical details (if you're
curious: the way v8 is implemented it installs security callback on global
object proxy and I don't want to put pointers to window impl on it).  I'll
address those issues with a separate CL.

IMPORTANT NOTE (sorry for the case): please, do not land this patch: if it
passes a review, I'd have to add a helper method to public V8 API (to lookup
real named property).


More information about the webkit-reviews mailing list