[webkit-reviews] review requested: [Bug 29521] run-webkit-tests: use require instead eval to load DumpRenderTreeSupport module : [Attachment 39821] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 19 10:21:04 PDT 2009


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 29521: run-webkit-tests: use require instead eval to load
DumpRenderTreeSupport module
https://bugs.webkit.org/show_bug.cgi?id=29521

Attachment 39821: Patch v1
https://bugs.webkit.org/attachment.cgi?id=39821&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).

The require statement is like the use statement, except that it
is run during script execution instead of during the 'BEGIN'
phase.	This makes it possible to change @INC before the require
statement is run.  See 'require' and 'use' in the perlfunc(1)
manpage and 'BEGIN' in perlmod(1) manpage.

* Scripts/run-webkit-tests: Replace eval statement with require
statement.
---
 2 files changed, 16 insertions(+), 1 deletions(-)


More information about the webkit-reviews mailing list