[webkit-reviews] review granted: [Bug 29206] post-diff and post-commits should be able to find bug urls in ChangeLogs. : [Attachment 39662] post-diff cleanups

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Eric Seidel
<eric at webkit.org>'s request for review:
Bug 29206: post-diff and post-commits should be able to find bug urls in
ChangeLogs.
https://bugs.webkit.org/show_bug.cgi?id=29206

Attachment 39662: post-diff cleanups
https://bugs.webkit.org/attachment.cgi?id=39662&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
> +	    - Fallback to bug urls in commit diffs, instead of just in commit
messages,
> +	      meaning post-commits will now find bug urls in ChangeLogs.

If this is for svn support, then it's fine.  Otherwise, I'd rather enforce
using the ChangeLog entries for commit logs.

> @@ -459,11 +459,17 @@ class ObsoleteAttachmentsOnBug(Command):
>  class PostDiffAsPatchToBug(Command):
>      def __init__(self):
>	   options = [
> +	       make_option("-m", "--description", action="store",
type="string", dest="description", help="Description string for the attachment
(default: 'patch')"),
> +	   ]
> +	   options += self.posting_options()
> +	   Command.__init__(self, 'Attaches the current working directory diff
to a bug as a patch file.', '[BUGID]', options=options)
> +
> +    @staticmethod
> +    def posting_options():
> +	   return [
>	       make_option("--no-obsolete", action="store_false",
dest="obsolete_patches", default=True, help="Do not obsolete old patches before
posting this one."),
>	       make_option("--no-review", action="store_false", dest="review",
default=True, help="Do not mark the patch for review."),
> -	       make_option("-m", "--description", action="store",
type="string", dest="description", help="Description string for the attachment
(default: 'patch')"),
>	   ]
> -	   Command.__init__(self, 'Attaches the current working directory diff
to a bug as a patch file.', 'BUGID', options=options)

Why is the -m|--description option listed separately?  It's also included
separately in PostCommitsAsPatchesToBug, so it should be included with
posting_options().

> +	       # Perfer --bug-id=, then a bug url in the commit message, then a
bug url in the entire commit diff (i.e. ChangeLogs).

Typo: "Perfer" should be "Prefer".

r=me