[webkit-reviews] review denied: [Bug 29502] basic inputs layout test for chromium : [Attachment 39797] fixed tabs in changelog.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 18 15:17:16 PDT 2009


Eric Seidel <eric at webkit.org> has denied Karen <karen+webkit at chromium.org>'s
request for review:
Bug 29502: basic inputs layout test for chromium
https://bugs.webkit.org/show_bug.cgi?id=29502

Attachment 39797: fixed tabs in changelog.
https://bugs.webkit.org/attachment.cgi?id=39797&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Now you have an extra space at the top of your ChangeLog file. :(

You might find http://webkit.org/coding/contributing.html#changelogs of
interest if you haven't already seen it.

Otherwise this looks fine.  I would r+ this, except you're not a committer so
it has to be perfect for the commit bot to land this for you. :(

While we're at it, "For chomium" is not a sentence, I assume you added an extra
period by mistake:
This tests all types of inputs text and password, both enabled and disabled,
the existing tests weren't thorough enough. For chromium.


More information about the webkit-reviews mailing list