[webkit-reviews] review denied: [Bug 29502] basic inputs layout test for chromium : [Attachment 39790] basic inputs layout test patch - added more info to changelog.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 18 14:56:27 PDT 2009


Eric Seidel <eric at webkit.org> has denied Karen <karen+webkit at chromium.org>'s
request for review:
Bug 29502: basic inputs layout test for chromium
https://bugs.webkit.org/show_bug.cgi?id=29502

Attachment 39790: basic inputs layout test patch - added more info to
changelog.
https://bugs.webkit.org/attachment.cgi?id=39790&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This also has tabs in the ChangeLog, which will make it impossible to land
automatically. :(

Missing a couple capital letters at the start of your sentences.

prepare-ChangeLog (the ChangeLog template generation tool) takes a --bug
argument which automatically inserts the bug url in the expected format in case
you need it in the future.  Generally the URL goes on its own line.

So asside from the ChagneLog nits, this looks fine.  but r- for the tabs.


More information about the webkit-reviews mailing list