[webkit-reviews] review requested: [Bug 29503] Implement ES5 Object.defineProperty function : [Attachment 39791] Implement ES5 Object.defineProperty function

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has asked  for review:
Bug 29503: Implement ES5 Object.defineProperty function
https://bugs.webkit.org/show_bug.cgi?id=29503

Attachment 39791: Implement ES5 Object.defineProperty function
https://bugs.webkit.org/attachment.cgi?id=39791&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
https://bugs.webkit.org/show_bug.cgi?id=29503

Reviewed by NOBODY(OOPS!)

Implement Object.defineProperty.  This requires adding the API to
ObjectConstructor, along with a helper function that implements the
ES5 internal [[ToPropertyDescriptor]] function.  It then adds
JSObject::defineOwnProperty that implements the appropriate ES5 semantics.
Currently defineOwnProperty uses a delete followed by a put to redefine
attributes of a property, clearly this is less efficient than it could be
but we can improve this if it needs to be possible in future.
---
 33 files changed, 921 insertions(+), 73 deletions(-)