[webkit-reviews] review granted: [Bug 29218] Write transactions should start with a BEGIN IMMEDIATE command : [Attachment 39730] patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 29218: Write transactions should start with a BEGIN IMMEDIATE command
https://bugs.webkit.org/show_bug.cgi?id=29218

Attachment 39730: patch
https://bugs.webkit.org/attachment.cgi?id=39730&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
OK.  I guess 2 more things I would have done if posting this patch to make the
reviewer's job a nobrainer would be:

1.  link to the SQLLite docs about this in the ChangeLog (assuming a direct
link to the section could be found).

2.  I would consider adding a comment next to:
+	 if (m_readOnly)
+	     m_inProgress = m_db.executeCommand("BEGIN;");
+	 else
+	     m_inProgress = m_db.executeCommand("BEGIN IMMEDIATE;");
to explain why we use BEGIN vs. BEGIN IMMEDIATE and what they do.  Possibly
also referencing the SQLLite docs url if you feel that's necessary.

So r+, but I would like you to make modifications like described above when
landing.  Or if you aren't a committer yet (I can never remember) and want this
commit-queue'd, then please post a new patch to be marked r+/cq+.