[webkit-reviews] review denied: [Bug 29332] REGRESSION (r48446): While a <select> popup menu is open, the rest of the WebView doesn't respond to mouse move events : [Attachment 39778] Patch v1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 29332: REGRESSION (r48446): While a <select> popup menu is open, the rest
of the WebView doesn't respond to mouse move events
https://bugs.webkit.org/show_bug.cgi?id=29332

Attachment 39778: Patch v1
https://bugs.webkit.org/attachment.cgi?id=39778&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +static void translatePoint(LPARAM& lParam, HWND from, HWND to) {

Please put the brace in a second line.

> +    // Protect the popup menu in case its owner is destroyed while we're
running the message pump.
> +    RefPtr<PopupMenu> protect(this);

I hate "protect" -- if there's any other way to make the lifetime work I would
prefer it. It's so hard to know when you need to protect something -- once we
add one of these it becomes voodoo code you can never remove. But it's better
than explicit ref/deref, that's for sure.

> +    if (event->type == NPCocoaEventMouseUp) {
> +	   NSBeep();
> +    }

Did you mean to land this?

>			buildSettings = {
> -				ARCHS =
"$(ARCHS_STANDARD_32_64_BIT_PRE_XCODE_3_1)";
> +				ARCHS = "$(ONLY_ACTIVE_ARCH_PRE_XCODE_3_1)";
>				ARCHS_STANDARD_32_64_BIT_PRE_XCODE_3_1 = "ppc
i386 ppc64 x86_64";
>				GCC_WARN_ABOUT_RETURN_TYPE = YES;
>				GCC_WARN_UNUSED_VARIABLE = YES;
> +				ONLY_ACTIVE_ARCH_PRE_XCODE_3_1 =
"$(NATIVE_ARCH)";
>				PREBINDING = NO;
> -				SDKROOT = /Developer/SDKs/MacOSX10.5.sdk;
> +				SDKROOT = "";
>			};

Did you mean to land this?

I'm going to say review- because of those example changes, but it's really
close to a review+