[webkit-reviews] review requested: [Bug 29341] REGRESSION: fast/workers/worker-cloneport.html failing intermittently on leopard bot : [Attachment 39773] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 18 12:04:17 PDT 2009


Andrew Wilson <atwilson at chromium.org> has asked  for review:
Bug 29341: REGRESSION: fast/workers/worker-cloneport.html failing
intermittently on leopard bot
https://bugs.webkit.org/show_bug.cgi?id=29341

Attachment 39773: proposed patch
https://bugs.webkit.org/attachment.cgi?id=39773&action=review

------- Additional Comments from Andrew Wilson <atwilson at chromium.org>
This test is intended to check for race conditions when cloning a port while
posting messages to it from another thread.

To ensure the case is adequately tested, we have some checks in place to make
sure that clones are actually happening in parallel with messages being posted.
The previous threshold (1000 clones) was chosen entirely arbitrarily, and
turned out to be a order of magnitude too strict for some platforms (like
Chromium). So I've loosened the requirement.

I also relaxed a timeout that fires only in the test failure case, again
because the latency involved in cross-process messaging in Chromium was causing
it to be flaky.


More information about the webkit-reviews mailing list