[webkit-reviews] review granted: [Bug 29362] Qt build error in GraphicsContextQt.cpp (qt 4.4.0) : [Attachment 39752] Qt build fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 18 11:36:07 PDT 2009


Eric Seidel <eric at webkit.org> has granted Fumitoshi Ukai <ukai at chromium.org>'s
request for review:
Bug 29362: Qt build error in GraphicsContextQt.cpp (qt 4.4.0)
https://bugs.webkit.org/show_bug.cgi?id=29362

Attachment 39752: Qt build fix
https://bugs.webkit.org/attachment.cgi?id=39752&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This looks fine, but you should explain why this is needed in the ChangeLog. 
It looks like QBrush(QPen) was marked as explicit in 4.4?

Please add some explanation to the ChangeLog on landing.


More information about the webkit-reviews mailing list