[webkit-reviews] review granted: [Bug 28327] Media layout tests should have a way to provide test files in different formats : [Attachment 39732] First round of changes - 8 patches

Fri Sep 18 10:50:46 PDT 2009

Eric Carlson <eric.carlson at apple.com> has granted Andrew Scherkus
<scherkus at chromium.org>'s request for review:
Bug 28327: Media layout tests should have a way to provide test files in
different formats
https://bugs.webkit.org/show_bug.cgi?id=28327

Attachment 39732: First round of changes - 8 patches
https://bugs.webkit.org/attachment.cgi?id=39732&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
> +++ b/LayoutTests/ChangeLog

> +	   * media/progress-event-total-expected.txt: Ditto

The only change to the expected results is to include the new event.total
value.

> +	   * media/progress-event-total.html: Ditto

Accomodates new file duration as well as switching to findMediaFile().

> +++ b/LayoutTests/media/event-attributes.html

>  
>      <body onload="start()">
>  
> -	   <video controls src="content/test.mp4" 
> +	   <video controls
>	       onabort="eventHandler()"
>	       oncanplay="eventHandler()"
>	       oncanplaythrough="eventHandler()"
> @@ -97,5 +99,9 @@
>	       >
>	   </video>
>  
> +	   <script>
> +	       setSrcByTagName("video", findMediaFile("video",
"content/test"));
> +	   </script>

Again, I would really prefer to have this done in the (existing) body load
event handler
instead of adding another script element.

r=me with these minor fixes.