[webkit-reviews] review denied: [Bug 29366] REGRESSION: formatting is broken in console.log() : [Attachment 39761] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 18 09:17:15 PDT 2009


Timothy Hatcher <timothy at hatcher.name> has denied Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 29366: REGRESSION: formatting is broken in console.log()
https://bugs.webkit.org/show_bug.cgi?id=29366

Attachment 39761: patch
https://bugs.webkit.org/attachment.cgi?id=39761&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> +	   if (typeof substitution == 'object' &&
Object.proxyType(substitution) == 'number') {
> +	       substitution = substitution.description;
> +	   }

Use === here. Also remove the braces.


> +	   if (typeof substitution == 'object' &&
Object.proxyType(substitution) == 'number') {
> +	       substitution = substitution.description;
> +	   }

Ditto.


> +	   if (typeof substitution == 'object' &&
Object.proxyType(substitution) != 'null') {
> +	       substitution = substitution.description;
> +	   }

Ditto.

Will r+ when those style changes are made.


More information about the webkit-reviews mailing list