[webkit-reviews] review denied: [Bug 29354] RVCT compile error in LiteralParser.cpp : [Attachment 39739] RVCT patch with comments

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 29354: RVCT compile error in LiteralParser.cpp
https://bugs.webkit.org/show_bug.cgi?id=29354

Attachment 39739: RVCT patch with comments
https://bugs.webkit.org/attachment.cgi?id=39739&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
A significant part of me wants to just reject this patch on the grounds that
you really need to update your compiler -- for instance we basically don't
accept patches to support gcc3 for instance.

That said, in its current form there's no question of accepting this patch as
it basically results in two copies of the same code, and adds a platform ifdef
to code that has no reason to have any ifdefs.	If we must use a macro then we
should just replace the function with a macro, not maintain both a macro and
function.