[webkit-reviews] review granted: [Bug 29321] Post the WebViewDidChangeSelectionNotification when text selection changes : [Attachment 39709] Updated patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Ada Chan
<adachan at apple.com>'s request for review:
Bug 29321: Post the WebViewDidChangeSelectionNotification when text selection
changes
https://bugs.webkit.org/show_bug.cgi?id=29321

Attachment 39709: Updated patch
https://bugs.webkit.org/attachment.cgi?id=39709&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> Index: WebKit/win/Interfaces/IWebEditingDelegate.idl
> ===================================================================
> --- WebKit/win/Interfaces/IWebEditingDelegate.idl	(revision 48477)
> +++ WebKit/win/Interfaces/IWebEditingDelegate.idl	(working copy)
> @@ -23,6 +23,8 @@
>   * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
>   */
>  
> +cpp_quote("#define WebViewDidChangeSelectionNotification
TEXT(\"WebViewDidChangeSelectionNotification\")")
> +

I'd put this in IWebView.idl, to match where it is defined in the Mac API.

r=me