[webkit-reviews] review requested: [Bug 29302] NPAPI plugin support feature on Webkit for S60 platform : [Attachment 39695] Patch with review comments incorporated

[bugzilla-daemon at webkit.org]

Rohini Ananth <rohini.ananth at nokia.com> has asked Simon Hausmann
<hausmann at webkit.org> for review:
Bug 29302: NPAPI plugin support feature on Webkit for S60 platform
https://bugs.webkit.org/show_bug.cgi?id=29302

Attachment 39695: Patch with review comments incorporated
https://bugs.webkit.org/attachment.cgi?id=39695&action=review

------- Additional Comments from Rohini Ananth <rohini.ananth at nokia.com>
Incorporating most of review comments and few others answered here...

Q: You can have XP_WIN and XP_SYMBIAN enabled as the same time?
A: Yes for winscw [debug version of s60], both get defined

Q:Do you really need a special Symbian container? or could we just make a
simple ifdef in the PluginContainerQt?
A: yes we would need a container class for handling scroll/zoom [gesture]
events later

Q:does this mean that you will be back working on windowless plugins ?
A: Current patch contains support for both windowed & windowless plugin :-)