[webkit-reviews] review requested: [Bug 29188] [Qt] Add persistence support for the "Always enable" options in the inspector : [Attachment 39690] Patch v0.3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 17 03:32:59 PDT 2009


Jocelyn Turcotte <jocelyn.turcotte at nokia.com> has asked  for review:
Bug 29188: [Qt] Add persistence support for the "Always enable" options in the
inspector
https://bugs.webkit.org/show_bug.cgi?id=29188

Attachment 39690: Patch v0.3
https://bugs.webkit.org/attachment.cgi?id=39690&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>
> > +	     retVal.setValue(static_cast<QString>(icSetting.string()));
> 
> Are all the manual casts from String to QString necessary? I thought we have
> automatic conversion for that.

This one is necessary since setValue is a template.
Other were to fix ambiguity operator+ error, using QLatin1String instead also
did the trick so I removed them.

Other comments have been applied in the patch, thx.


More information about the webkit-reviews mailing list