[webkit-reviews] review granted: [Bug 29318] Update contributing.html to mention recently added tools. : [Attachment 39664] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 16 22:33:46 PDT 2009


Darin Adler <darin at apple.com> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 29318: Update contributing.html to mention recently added tools.
https://bugs.webkit.org/show_bug.cgi?id=29318

Attachment 39664: Patch v1
https://bugs.webkit.org/attachment.cgi?id=39664&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -    <li>Upload the patch for review. In Bugzilla, be sure to set the
<tt>review:?</tt> flag.</li>
> +    <li>Upload the patch for review. In Bugzilla, be sure to mark your file
as a patch and set the <tt>review:?</tt> flag.</li>

I think this could be slightly more explicit; it may not be obvious there is a
check box labeled "patch" they have to check. But I don't have better wording
to suggest.


More information about the webkit-reviews mailing list