[webkit-reviews] review granted: [Bug 29319] Reorganizing helper functions in htmlediting.h : [Attachment 39666] Patch2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 16 17:12:39 PDT 2009
Eric Seidel <eric at webkit.org> has granted Enrica Casucci <enrica at apple.com>'s
request for review:
Bug 29319: Reorganizing helper functions in htmlediting.h
https://bugs.webkit.org/show_bug.cgi?id=29319
Attachment 39666: Patch2
https://bugs.webkit.org/attachment.cgi?id=39666&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Welcome to WebKit! :)
Seems there is an extra newline after isAtUnsplittableElement.
I wonder why this doesn't return HTMLElement:
118202 PassRefPtr<Element> createTabSpanElement(Document*);
(You shouldn't change it now, just noting.)
Space after a period?
15 (WebCore::isAtUnsplittableElement): added.The code has been taken
from IndentOutdentCommand.
This looks fine though. Either you can get someone to commit this for you with
modifications, or you can post a new patch with the spacing fixed and the
commit queue could take care of this. Your call.
More information about the webkit-reviews
mailing list