[webkit-reviews] review requested: [Bug 29315] Add a UI delegate callback to let the delegate draw a WebView's background : [Attachment 39661] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 16 14:42:00 PDT 2009


Adam Roben (aroben) <aroben at apple.com> has asked  for review:
Bug 29315: Add a UI delegate callback to let the delegate draw a WebView's
background
https://bugs.webkit.org/show_bug.cgi?id=29315

Attachment 39661: Patch v1
https://bugs.webkit.org/attachment.cgi?id=39661&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
Need a short description and bug URL (OOPS!)

Reviewed by NOBODY (OOPS!).

* Interfaces/IWebUIDelegatePrivate.idl: Added
IWebUIDelegatePrivate2::drawBackground.

* WebView.cpp:
(WebView::paintIntoBackingStore): After clearing or filling with
white, let the delegate draw whatever background it wants. Also added
an assertion that the dirty rect is within our bounds.
---
 3 files changed, 30 insertions(+), 0 deletions(-)


More information about the webkit-reviews mailing list