[webkit-reviews] review denied: [Bug 29103] typeAheadFind in select element is case-sensitive for Cyrillic and Greek : [Attachment 39415] a quick fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 16 08:38:56 PDT 2009


Adam Roben (aroben) <aroben at apple.com> has denied Hironori Bono
<hbono at chromium.org>'s request for review:
Bug 29103: typeAheadFind in select element is case-sensitive for Cyrillic and
Greek
https://bugs.webkit.org/show_bug.cgi?id=29103

Attachment 39415: a quick fix
https://bugs.webkit.org/attachment.cgi?id=39415&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
This seems like an awfully broad fix for such a specific symptom. Are there
other bugs caused by reverseFind using toASCIILower? If the new way is
better/more correct, wouldn't we want find to work the same way? What
performance impact does this have?

r- so we can figure out the above issues.


More information about the webkit-reviews mailing list