[webkit-reviews] review denied: [Bug 28884] Add CreateRequestExtension to QWebPage : [Attachment 39517] Updated Patch

[bugzilla-daemon at webkit.org]

Ariya Hidayat <ariya.hidayat at trolltech.com> has denied robert
<robert at roberthogan.net>'s request for review:
Bug 28884: Add CreateRequestExtension to QWebPage
https://bugs.webkit.org/show_bug.cgi?id=28884

Attachment 39517: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=39517&action=review

------- Additional Comments from Ariya Hidayat <ariya.hidayat at trolltech.com>
> +    // Calling CreateRequestExtension allows clients who implement it to
perform
> +    // operations on the QNetworkRequest::Attributes. For example, clients
could
> +    // store a pointer to the frame in QNetworkRequest::User + X. This would
allow
> +    // the client to associate the network request with it's originating
frame.
> +    QWebPage::CreateRequestExtensionOption option;
> +    option.frame = d->m_frame;
> +    option.request = m_request;
> +    option.type = QWebPage::NavigationTypeOther;
> +
> +    QWebPage::CreateRequestExtensionReturn output;
> +    if (d->m_frame->page()->extension(QWebPage::CreateRequestExtension,
&option, &output))
> +	   m_request = output.request;

I am not sure about this part. Seems that we will need to construct both
structures even in the case (probably 90%) where this extension will not be
used by the client.
That seems like a waste.

Is there a way to not support the extension by default?