[webkit-reviews] review denied: [Bug 29092] Performance slow when loading a large text html file on Symbian platform : [Attachment 39550] fix patch for the bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 16 06:08:30 PDT 2009


Ariya Hidayat <ariya.hidayat at trolltech.com> has denied Chang Shu
<Chang.Shu at nokia.com>'s request for review:
Bug 29092: Performance slow when loading a large text html file on Symbian
platform
https://bugs.webkit.org/show_bug.cgi?id=29092

Attachment 39550: fix patch for the bug
https://bugs.webkit.org/attachment.cgi?id=39550&action=review

------- Additional Comments from Ariya Hidayat <ariya.hidayat at trolltech.com>
> +	   Optimize the code so only the text from start to end is scaned.

Typo: scanned.

> +	   On a platform with webkit+Qt+Symbian, the parsing time for a 600K
text
> +	   file improved 90% and overall loading time improved 20%.

Could you use less ambiguous text? Improved by 90% means what?
Suggested: improved from 100 ms to 75 ms (1.33x faster).


More information about the webkit-reviews mailing list