[webkit-reviews] review denied: [Bug 29106] [Qt] make CachedResourceHandle.h compile in winscw Symbian compiler. : [Attachment 39320] don't inline CachedResourceHandle<T>(R*) for winscw compiler.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 15 23:15:33 PDT 2009


Eric Seidel <eric at webkit.org> has denied Yongjun Zhang
<yongjun.zhang at nokia.com>'s request for review:
Bug 29106: [Qt] make CachedResourceHandle.h compile in winscw Symbian compiler.
https://bugs.webkit.org/show_bug.cgi?id=29106

Attachment 39320: don't inline CachedResourceHandle<T>(R*) for winscw compiler.
https://bugs.webkit.org/attachment.cgi?id=39320&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
See my comments on your other bug about "inline" for templates functions.

Style:
+	 CachedResourceHandle(R* res);

We need a comment which references the bug.  The compiler bug should be linked
to from the ChangeLog too.


More information about the webkit-reviews mailing list