[webkit-reviews] review granted: [Bug 29146] stdint and stdbool should check for msvc compiler and not the windows platform : [Attachment 39433] patch + updated error and comment

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 15 23:10:54 PDT 2009


Eric Seidel <eric at webkit.org> has granted Benjamin Meyer <ben at meyerhome.net>'s
request for review:
Bug 29146: stdint and stdbool should check for msvc compiler and not the
windows platform
https://bugs.webkit.org/show_bug.cgi?id=29146

Attachment 39433: patch + updated error and comment
https://bugs.webkit.org/attachment.cgi?id=39433&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks sane enough to me.  Since it doesn't look like you're a committer yet
(http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py
) adding this to the commit-queue on your behalf.


More information about the webkit-reviews mailing list