[webkit-reviews] review denied: [Bug 29187] Don't inline ~ListRefPtr() to workaround winscw compiler forward declaration limitation. : [Attachment 39449] Don't inline ~ListRefPtr for winscw compiler, keep it inlined for other compilers.

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Yongjun Zhang
<yongjun.zhang at nokia.com>'s request for review:
Bug 29187: Don't inline ~ListRefPtr() to workaround winscw compiler forward
declaration limitation.
https://bugs.webkit.org/show_bug.cgi?id=29187

Attachment 39449: Don't inline ~ListRefPtr for winscw compiler, keep it inlined
for other compilers.
https://bugs.webkit.org/attachment.cgi?id=39449&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Maybe I don't understand C++ well enough, but I don't understand how you can
have non-inline template code in a header.  I don't see what the "inline"
keyword would do here, the destructor will always be inlined, no?

Also, this needs a comment in the code and a link to the winscw bug.

What is being forward declared here that winscw can't understand?