[webkit-reviews] review denied: [Bug 27514] add support for watched expressions : [Attachment 39610] proposed patch - 2009/09/15

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has denied Patrick Mueller
<pmuellr at yahoo.com>'s request for review:
Bug 27514: add support for watched expressions
https://bugs.webkit.org/show_bug.cgi?id=27514

Attachment 39610: proposed patch - 2009/09/15
https://bugs.webkit.org/attachment.cgi?id=39610&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> +	  
properties.sort(rootTreeElementConstructor.prototype.comparePropertyNames);

This should just be rootTreeElementConstructor.comparePropertyNames, to allow
instances to override the prototype.

> +	       if (property.name === " ") 

Maybe everywhere you check for " " you should just trim whitspace
(String.trimWhitespace in utilities.js) and look for "" or !property.name?

I would r+ this, but I would like to see the prototype thing fixed, even though
it isn't an issue today.