[webkit-reviews] review requested: [Bug 27514] add support for watched expressions : [Attachment 39610] proposed patch - 2009/09/15

[bugzilla-daemon at webkit.org]

Patrick Mueller <pmuellr at yahoo.com> has asked  for review:
Bug 27514: add support for watched expressions
https://bugs.webkit.org/show_bug.cgi?id=27514

Attachment 39610: proposed patch - 2009/09/15
https://bugs.webkit.org/attachment.cgi?id=39610&action=review

------- Additional Comments from Patrick Mueller <pmuellr at yahoo.com>
All the suggested changes were made.

Additional things:

- I had to move the displaySort business around - turns out I wasn't sorting
the properties inside the expressions themselves in the WatchExpressions
correctly.  To get this to work right for all the ObjectProperty* bits, the
functionality was moved to the tree element prototype.	The sort logic itself
was unchanged.

- the callback in ObjectPropertyTreeElement.onpopulate() wasn't working
correctly, but I couldn't figure out why; changed from using the "self = this"
type of closure reference to bind(this) on the callback, which worked fine.

- had to make the ": " element in the property items a span itself, so I could
hide it during edit

- changed the edit code to use css to turn the name span into a block element
with width:100%.  Looks better.  No nbsp hacks!