[webkit-reviews] review granted: [Bug 28841] WAI-ARIA: add support for ranges, including the progressbar, slider, and spinbutton roles : [Attachment 39506] updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 15 12:18:26 PDT 2009


Beth Dakin <bdakin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 28841: WAI-ARIA: add support for ranges, including the progressbar, slider,
and spinbutton roles
https://bugs.webkit.org/show_bug.cgi?id=28841

Attachment 39506: updated patch
https://bugs.webkit.org/attachment.cgi?id=39506&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
Looks good!

It's true that this is technically not a js test. I only recently learned about
js tests myself, and I have made a few of them recently. I agree with Chris
that I dislike having two files. That combined with the fact that we have some
like this checked into the accessibility tests anyway, I am going to r+ this.
Personally, I like this style better anyway.


More information about the webkit-reviews mailing list