[webkit-reviews] review denied: [Bug 29243] Update Chromium Mac render theme files : [Attachment 39603] Patch with svn cp used to mark origins of files

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Avi Drissman
<avi at drissman.com>'s request for review:
Bug 29243: Update Chromium Mac render theme files
https://bugs.webkit.org/show_bug.cgi?id=29243

Attachment 39603: Patch with svn cp used to mark origins of files
https://bugs.webkit.org/attachment.cgi?id=39603&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/ChangeLog
...
> +	   http://crbug.com/19604

No need for the crbug reference since you mention the bugs.webkit.org link.


> Index: WebCore/platform/graphics/FloatPoint.h
> +#if (PLATFORM(MAC) && !defined(NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES)) \

> +	 || (PLATFORM(CHROMIUM) && PLATFORM(DARWIN))

nit: indent by 8 spaces instead of 6.  normal indent is 4 spaces, so 2x that
seems appropriate for a line continuation.


> Index: WebCore/platform/graphics/FloatRect.h
...
> +#if (PLATFORM(MAC) && !defined(NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES)) \

> +	 || (PLATFORM(CHROMIUM) && PLATFORM(DARWIN))

ditto


> Index: WebCore/platform/graphics/FloatSize.h
...
> +#if (PLATFORM(MAC) && !defined(NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES)) \

> +	 || (PLATFORM(CHROMIUM) && PLATFORM(DARWIN))

ditto


> Index: WebCore/platform/graphics/IntRect.h
...
> +#if (PLATFORM(MAC) && !defined(NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES)) \

> +	 || (PLATFORM(CHROMIUM) && PLATFORM(DARWIN))
...
> +#if (PLATFORM(MAC) && !defined(NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES)) \

> +	 || (PLATFORM(CHROMIUM) && PLATFORM(DARWIN))

ditto