[webkit-reviews] review denied: [Bug 29193] [chromium] Need to prevent Javascript sleeps in unload handlers : [Attachment 39590] Update Skipped files for other platforms

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 15 08:57:02 PDT 2009


Adam Barth <abarth at webkit.org> has denied John Abd-El-Malek
<jam at chromium.org>'s request for review:
Bug 29193: [chromium] Need to prevent Javascript sleeps in unload handlers
https://bugs.webkit.org/show_bug.cgi?id=29193

Attachment 39590: Update Skipped files for other platforms
https://bugs.webkit.org/attachment.cgi?id=39590&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I really don't think this is the right approach.  This doesn't actually solve
the problem.  Sites that want to sleep in their unload handlers will just
resort to a Yet More Ridiculous Hack and save the original getTime function.

The proper way to solve this problem is to give V8 a time bound for running the
unload handler and have V8 terminate the script internally.  Hacking around
with the global JS environment is prone to disaster.


More information about the webkit-reviews mailing list