[webkit-reviews] review granted: [Bug 29268] [Qt] JSVALUE32_64 not works on Windows platform with MinGW compiler : [Attachment 39591] proposed patch

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <vestbo at webkit.org> has granted Csaba Osztrogonác
<oszi at inf.u-szeged.hu>'s request for review:
Bug 29268: [Qt] JSVALUE32_64 not works on Windows platform with MinGW compiler
https://bugs.webkit.org/show_bug.cgi?id=29268

Attachment 39591: proposed patch
https://bugs.webkit.org/attachment.cgi?id=39591&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
> +/* On PLATFORM(WIN_OS) with COMPILER(MINGW) JSVALUE32_64 crashes,
temporarily disabled */

You want to comment on _why_, and mention the bug, for example:

#elif PLATFORM(WIN_OS) && COMPILER(MINGW)
/* MinGW messes up the padding/alignment when using JSVALUE64, which
causes crashes. See https://bugs.webkit.org/show_bug.cgi?id=29268 */
#define WTF_USE_JSVALUE32 1
#else

I'll fix this when landing