[webkit-reviews] review canceled: [Bug 29122] Use PLATFORM(ARM_THUMB2) instead of PLATFORM_ARM_ARCH(7) : [Attachment 39345] Use PLATFORM(ARM_THUMB2) instead of PLATFORM_ARM_ARCH(7)

[bugzilla-daemon at webkit.org]

Gabor Loki <loki at inf.u-szeged.hu> has canceled Gabor Loki
<loki at inf.u-szeged.hu>'s request for review:
Bug 29122: Use PLATFORM(ARM_THUMB2) instead of PLATFORM_ARM_ARCH(7)
https://bugs.webkit.org/show_bug.cgi?id=29122

Attachment 39345: Use PLATFORM(ARM_THUMB2) instead of PLATFORM_ARM_ARCH(7)
https://bugs.webkit.org/attachment.cgi?id=39345&action=review

------- Additional Comments from Gabor Loki <loki at inf.u-szeged.hu>
This patch introduce WTF_PLATFORM_ARM_TRADITIONAL and WTF_PLATFORM_ARM_THUMB2
pseudo-platforms according to Gavin suggestion on irc.

The PLATFORM_ARM_ARCH(7) is replaced with PLATFORM(ARM_THUMB2) and the
PLATFORM(ARM) && !PLATFORM_ARM_ARCH(7) is replaced with
PLATFORM(ARM_TRADITIONAL). The common code is still under PLATFORM(ARM) #if
checks.

By default the WTF_PLATFORM_ARM_THUMB2 is set when 'thumb2' or '__thumb2__'
compiler directives are set. Otherwise if the target ARM architecture is v4 or
above, WTF_PLATFORM_ARM_TRADITIONAL is set.

This gives an opportunity to use JIT with ARM instruction set on ARMv7 as well.