[webkit-reviews] review granted: [Bug 29263] Add option to run-webkit-tests to repeat the tests N times : [Attachment 39580] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 14 17:48:07 PDT 2009
Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 29263: Add option to run-webkit-tests to repeat the tests N times
https://bugs.webkit.org/show_bug.cgi?id=29263
Attachment 39580: Patch
https://bugs.webkit.org/attachment.cgi?id=39580&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> +if ($iterations) {
> + my @orig_tests = @tests;
> + for (my $i = 1; $i < $iterations; $i++) {
> + push(@tests, @orig_tests);
> + }
> +}
No need for the if -- it works fine without it and just copies the array once.
We normally name these things like @originalTests rather than $origTests.
r=me
More information about the webkit-reviews
mailing list