[webkit-reviews] review granted: [Bug 29160] Safari 4 unable to change settings on Linksys Routers : [Attachment 39554] Updated fix - Same code changes as my Saturday patch, but a new layout test for the "resending the same wrong credentials" behavior.

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 29160: Safari 4 unable to change settings on Linksys Routers
https://bugs.webkit.org/show_bug.cgi?id=29160

Attachment 39554: Updated fix - Same code changes as my Saturday patch, but a
new layout test for the "resending the same wrong credentials" behavior.
https://bugs.webkit.org/attachment.cgi?id=39554&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
+    const HashMap<String, Credential>&
pathToCredentialMap(originToDefaultBasicCredentialMap().get(origin));

Good catch with copying the map!

+	 Credential m_initialCredential;

This seems difficult to understand without a context, I think it's worth a
comment (yeah, copied many times).

+	 NSLog(@"Telling send to use %@ for challenge %@", mac(webCredential),
d->m_currentMacChallenge);

Looks unintentional (maybe there's something to log with WebCore mechanisms
though?) 

r=me