[webkit-reviews] review denied: [Bug 28983] WebInspector: Wrap primitive values (as objects) in InspectorController::wrap : [Attachment 39536] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 14 10:17:15 PDT 2009
Timothy Hatcher <timothy at hatcher.name> has denied Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 28983: WebInspector: Wrap primitive values (as objects) in
InspectorController::wrap
https://bugs.webkit.org/show_bug.cgi?id=28983
Attachment 39536: patch
https://bugs.webkit.org/attachment.cgi?id=39536&action=review
------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> diff --git a/WebCore/inspector/InspectorController.cpp
b/WebCore/inspector/InspectorController.cpp
> + try {
> + var expressionResult =
InjectedScript._evaluateOn(InjectedScript._window().eval,
InjectedScript._window(), expression);
> + for (var prop in expressionResult)
> + props[prop] = true;
> + if (includeInspectorCommandLineAPI)
> + for (var prop in
InjectedScript._window()._inspectorCommandLineAPI)
> + if (prop.charAt(0) !== '_')
> + props[prop] = true;
> + } catch(e) {
> + }
> + return props;
I still see 2 space indents (only on one level.)
More information about the webkit-reviews
mailing list