[webkit-reviews] review granted: [Bug 29238] CodeGenerator.pm needs some cleaning up : [Attachment 39533] Patch v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 14 09:58:09 PDT 2009
Eric Seidel <eric at webkit.org> has granted Cameron McCormack <cam at mcc.id.au>'s
request for review:
Bug 29238: CodeGenerator.pm needs some cleaning up
https://bugs.webkit.org/show_bug.cgi?id=29238
Attachment 39533: Patch v1
https://bugs.webkit.org/attachment.cgi?id=39533&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
This is mostly a rubber stamp. But the change looks good as far as I can tell.
I'm *so glad* to see someone working on this again. :) I'd still love to see
us re-write this in python with a real parser (instead of regexps), but this
it's good to see cleanup!
More information about the webkit-reviews
mailing list