[webkit-reviews] review denied: [Bug 29123] Fails to parse the "d" attribute of a path if a command starts with a '.' : [Attachment 39544] patch that fixes SVG path tat starts with dot '.'

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 14 07:52:51 PDT 2009


Darin Adler <darin at apple.com> has denied Charles Wei
<charles.wei at torchmobile.com.cn>'s request for review:
Bug 29123: Fails to parse the "d" attribute of a path if a command starts with
a '.'
https://bugs.webkit.org/show_bug.cgi?id=29123

Attachment 39544: patch that fixes SVG path tat starts with dot '.'
https://bugs.webkit.org/attachment.cgi?id=39544&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
In the WebKit project we require regression tests checked in along with bug
fixes.

There's already a test of the path parser in
LayoutTests/svg/dom/path-parser.html so for this bug you could probably add
some tests cases to that.

review- because of lack of a test


More information about the webkit-reviews mailing list