[webkit-reviews] review granted: [Bug 28899] WebKit should broadcast an MSAA event when jumping to a named anchor : [Attachment 39504] patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Jon Honeycutt
<jhoneycutt at apple.com>'s request for review:
Bug 28899: WebKit should broadcast an MSAA event when jumping to a named anchor
https://bugs.webkit.org/show_bug.cgi?id=28899

Attachment 39504: patch
https://bugs.webkit.org/attachment.cgi?id=39504&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +    DWORD msaaEvent;
> +    switch (notification) {
> +	   case AXFocusedUIElementChanged:
> +	       msaaEvent = EVENT_OBJECT_FOCUS;
> +	       break;
> +
> +	   case AXScrolledToAnchor:
> +	       msaaEvent = EVENT_SYSTEM_SCROLLINGSTART;
> +	       break;
> +
> +	   default:
> +	       return;
> +    }

It might be clearer to use a HashMap, though it probably doesn't matter as long
as we only have two events we care about.

> +    // Windows will end up calling get_accChild() on the root accessible
> +    // object for the WebView, passing the child ID that we specify below.
We
> +    // negate the AXID so we know that the caller is passing the ID of an
> +    // element, not the index of a child element.
> +
> +    ASSERT(obj->axObjectID() >= 1 && obj->axObjectID() <=
numeric_limits<LONG>::max());

You should split this up into two assertions.

r=me