[webkit-reviews] review requested: [Bug 29160] Safari 4 unable to change settings on Linksys Routers : [Attachment 39519] Patch with changes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 12 15:36:59 PDT 2009


Brady Eidson <beidson at apple.com> has asked Alexey Proskuryakov <ap at webkit.org>
for review:
Bug 29160: Safari 4 unable to change settings on Linksys Routers
https://bugs.webkit.org/show_bug.cgi?id=29160

Attachment 39519: Patch with changes
https://bugs.webkit.org/attachment.cgi?id=39519&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
Except for the unanswered question about credential encoding, which I'm sure we
get wrong in plenty of other contexts, this patch addresses all of Alexeys
comments, including most importantly:
-Not sending the same incorrect credentials twice in a row
and
-Not storing credentials on 407 (by limiting to 401 only)


More information about the webkit-reviews mailing list