[webkit-reviews] review requested: [Bug 29225] Add ENABLE(CONTEXT_MENU) : [Attachment 39518] This patch implements the needed changes
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Sep 12 14:36:25 PDT 2009
Greg Bolsinga <bolsinga at apple.com> has asked for review:
Bug 29225: Add ENABLE(CONTEXT_MENU)
https://bugs.webkit.org/show_bug.cgi?id=29225
Attachment 39518: This patch implements the needed changes
https://bugs.webkit.org/attachment.cgi?id=39518&action=review
------- Additional Comments from Greg Bolsinga <bolsinga at apple.com>
This will compile and link Mac OS X without Context Menu support.
Of course Mac OS X (and many other platforms) will never ship in this
configuration, so should the Mac code be conditionally compiled for this?
I also left in the oncontextmenu event / attribute, since it just doesn't do
anything on iPhone. Is this best?
More information about the webkit-reviews
mailing list