[webkit-reviews] review denied: [Bug 28983] WebInspector: Wrap primitive values (as objects) in InspectorController::wrap : [Attachment 39428] patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has denied Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 28983: WebInspector: Wrap primitive values (as objects) in
InspectorController::wrap
https://bugs.webkit.org/show_bug.cgi?id=28983

Attachment 39428: patch
https://bugs.webkit.org/attachment.cgi?id=39428&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> +    try {
> +	 var expressionResult =
InjectedScript._evaluateOn(InjectedScript._window().eval,
InjectedScript._window(), expression);
> +	 for (var prop in expressionResult)
> +	     props[prop] = true;
> +	 if (includeInspectorCommandLineAPI)
> +	     for (var prop in
InjectedScript._window()._inspectorCommandLineAPI)
> +		 if (prop.charAt(0) !== '_')
> +		     props[prop] = true;
> +    } catch(e) {
> +    }
> +    return props;

Looks fine, but you use 2 space indentation in the try block.