[webkit-reviews] review denied: [Bug 29204] Compile KeyframeList.cpp and AnimationBase.cpp in winscw compiler. : [Attachment 39472] Move setAnimation() and KeyframeList() ctor to respective cpp files.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 11 16:45:27 PDT 2009
Eric Seidel <eric at webkit.org> has denied Yongjun Zhang
<yongjun.zhang at nokia.com>'s request for review:
Bug 29204: Compile KeyframeList.cpp and AnimationBase.cpp in winscw compiler.
https://bugs.webkit.org/show_bug.cgi?id=29204
Attachment 39472: Move setAnimation() and KeyframeList() ctor to respective cpp
files.
https://bugs.webkit.org/attachment.cgi?id=39472&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Why are these changes needed? And why are we supporting this broken compiler...
;) The number of fixes needed to make winscw work seems to be growing without
bound.
r-. We need more explanation for each of these (seemingly arbitrary) changes,
and ideally links to compiler bugs you've filed with the winscw folks.
More information about the webkit-reviews
mailing list