[webkit-reviews] review granted: [Bug 28980] [V8] Run-time exception in onmessage handler is not forwarded to the worker object. : [Attachment 39289] Proposed Patch 2

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 28980: [V8] Run-time exception in onmessage handler is not forwarded to the
worker object.
https://bugs.webkit.org/show_bug.cgi?id=28980

Attachment 39289: Proposed Patch 2
https://bugs.webkit.org/attachment.cgi?id=39289&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Just a few nits to fix on landing.

> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> +	   The previous fix is partially reverted due to reliability build
break

s/is/was/

s/to/to a/

> +	   in chromium. The break happens when an exception is thrown without
> +	   setting a message. We need to check for this scenario and handle it.


No need to change this but for future reference, in general this type of
comment can go with the function where you are doing the check and handling it.


> diff --git a/WebCore/bindings/v8/V8AbstractEventListener.cpp
b/WebCore/bindings/v8/V8AbstractEventListener.cpp
> +	   tryCatch.SetVerbose(false);	 // We do not want to report the
exception to the inspector console.

Single space before end of line comment.