[webkit-reviews] review denied: [Bug 29139] Add variant to WebGL uniform* and vertexAttrib* calls : [Attachment 39484] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 11 15:58:58 PDT 2009


Oliver Hunt <oliver at apple.com> has denied Chris Marrin <cmarrin at apple.com>'s
request for review:
Bug 29139: Add variant to WebGL uniform* and vertexAttrib* calls
https://bugs.webkit.org/show_bug.cgi?id=29139

Attachment 39484: Patch
https://bugs.webkit.org/attachment.cgi?id=39484&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
I don't like the many examples of code like
"static_cast<float*>(v->baseAddress())" -- i would prefer CanvasFooArray all
have a Foo* data() const { return stati_cast<Foo*>(baseAddress()); } methods
that you would use instead.


More information about the webkit-reviews mailing list