[webkit-reviews] review denied: [Bug 28986] Add support for noreferrer link relation : [Attachment 39463] Attempt #2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 11 15:27:08 PDT 2009
Alexey Proskuryakov <ap at webkit.org> has denied Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 28986: Add support for noreferrer link relation
https://bugs.webkit.org/show_bug.cgi?id=28986
Attachment 39463: Attempt #2
https://bugs.webkit.org/attachment.cgi?id=39463&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> Sorry for not explaining sooner. Does that seem reasonable?
Probably - it's the first time I see this class, so I do not have a strong
opinion. Does rel attribute value parsing depend on compatMode?
It also seems quite wasteful to temporarily construct a class with a vector of
AtomicStrings just to check if there's a value in the space-separated list.
However, if we decide to reuse the class, it needs to be renamed back.
Marking r-, as the patch will be updated, at least per your above comment.
More information about the webkit-reviews
mailing list