[webkit-reviews] review granted: [Bug 29195] Web Inspector Console should have scope bars : [Attachment 39452] Console Scope Bars
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 11 12:02:25 PDT 2009
Timothy Hatcher <timothy at hatcher.name> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 29195: Web Inspector Console should have scope bars
https://bugs.webkit.org/show_bug.cgi?id=29195
Attachment 39452: Console Scope Bars
https://bugs.webkit.org/attachment.cgi?id=39452&action=review
------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> + var createFilterElement = function (category) {
This is better written as:
function createFilterElement(category)
{
> + };
Thers is a stray indent space before the "}" brace. No need for the semicolon.
> + display: list-item;
This should be display: block;
Looks good, if you fix these three things.
More information about the webkit-reviews
mailing list