[webkit-reviews] review denied: [Bug 29191] Add implementation of texImage2D that takes CanvasArray : [Attachment 39447] Patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Chris Marrin <cmarrin at apple.com>'s
request for review:
Bug 29191: Add implementation of texImage2D that takes CanvasArray
https://bugs.webkit.org/show_bug.cgi?id=29191

Attachment 39447: Patch
https://bugs.webkit.org/attachment.cgi?id=39447&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
> +	   unsigned internalformat = args.at(2).toInt32(exec);
> +	   unsigned width = args.at(3).toInt32(exec);
> +	   unsigned height = args.at(4).toInt32(exec);
> +	   unsigned border = args.at(5).toInt32(exec);
> +	   unsigned format = args.at(6).toInt32(exec);
> +	   unsigned type = args.at(7).toInt32(exec);
> +	   CanvasArray* array = toCanvasArray(args.at(8));

You have no guarantee that this is actually a canvas array, so you need to do a
type check and throw a typeerror or whatever.  Additionally all of these
conversions can throw exceptions so *technically* there should be an exception
check following each one.