[webkit-reviews] review requested: [Bug 28886] Build error using JIT with gcc 4.1.2 and ARM v5 : [Attachment 39430] Be more specific with guards.

[bugzilla-daemon at webkit.org]

Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 28886: Build error using JIT with gcc 4.1.2 and ARM v5
https://bugs.webkit.org/show_bug.cgi?id=28886

Attachment 39430: Be more specific with guards.
https://bugs.webkit.org/attachment.cgi?id=39430&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
1./ It looks to me that not only the __clear_cache call but also the fallback
assembly assumes GCC (as the assembly syntax is compiler specific) - so maybe
this whole code section should be guarded with COMPILER(GCC).

2./ It might be better to use the CLEAR_INSN_CACHE guard to test if
__clear_cache is available than testing for a specific GCC version. Andre can
you see if CLEAR_INSN_CACHE is defined in your environment.

3./ The fallback ARM code seems to call a Linux system call and as such it
would only work on Linux, so maybe we should have a guard for that as well. 

4./ I would also suggest #error messages for the platforms currently not
supported