[webkit-reviews] review canceled: [Bug 28303] [Qt] XSLT support with QtXmlPatterns : [Attachment 39384] [Qt] Implement XSLT support with QtXmlPatterns.

[bugzilla-daemon at webkit.org]

Jakub Wieczorek <faw217 at gmail.com> has canceled Jakub Wieczorek
<faw217 at gmail.com>'s request for review:
Bug 28303: [Qt] XSLT support with QtXmlPatterns
https://bugs.webkit.org/show_bug.cgi?id=28303

Attachment 39384: [Qt] Implement XSLT support with QtXmlPatterns.
https://bugs.webkit.org/attachment.cgi?id=39384&action=review

------- Additional Comments from Jakub Wieczorek <faw217 at gmail.com>
(In reply to comment #39)
> (In reply to comment #38)
> > Created an attachment (id=39384) [details] [details]
> > [Qt] Implement XSLT support with QtXmlPatterns.
> > 
> > - Add the TransformSource class.
> > - Fix build with Qt < 4.5 (disable xslt by default for older versions).
> 
> Hi Jakub, as far as I know QtXmlPatterns module is only build when Qt is
built
> with exception support. How does this patch affect QtWebKit inside Qt, when
Qt
> is compiled without exception support?

Indeed, the patch assumed that Qt has been built with the QtXmlPatterns module.

This one fixes that by enabling XSLT support only with Qt >= 4.5 _and_ when
QtXmlPatterns is available.

Apart from that, fixed libxslt-based build breakage and some compiler warnings.