[webkit-reviews] review requested: [Bug 29175] JavaScriptCore: corrects build break on sparc 64 with gcc : [Attachment 39420] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 11 03:09:01 PDT 2009


Jocelyn Turcotte <jocelyn.turcotte at nokia.com> has asked  for review:
Bug 29175: JavaScriptCore: corrects build break on sparc 64 with gcc
https://bugs.webkit.org/show_bug.cgi?id=29175

Attachment 39420: Patch
https://bugs.webkit.org/attachment.cgi?id=39420&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>
Compiling JavaScriptCore on sparc 64 with gcc fails.

ThreadSafeShared uses the atomic __gnu_cxx::__exchange_and_add with an int,
however on sparc 64 the _Atomic_word argument is typedefed to long (8 bytes).

The patch disables WTF_USE_LOCKFREE_THREADSAFESHARED in ThreadSafeShared to use
a mutex instead when compiling for sparc 64 with gcc.


More information about the webkit-reviews mailing list